final commit #2670
Closed
final commit #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danon321
suggested changes
Nov 24, 2024
Zibi95
suggested changes
Dec 3, 2024
There was a problem hiding this comment.
Hey,
Please check the title sizes across all devices and the spacing between elements. It doesn’t have to be pixel-perfect, but the differences are too significant.
I can see scroll in the navigation menu. When its not needed.
When navigation menu has smaller height scroll doesn't work
These link are way to much separated. Look at figma, also font weight on desktop is smaller than in figma
This spacing is too big
This one too
These titles are too small on desktop
Email also have its special href that triggers app for emails
Zibi95
suggested changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://GrzegorzLasota.github.io/layout_miami/