-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace simple-phpunit
with phpunit
#31
Merged
alexander-schranz
merged 4 commits into
massiveart:0.5
from
mamazu:fixing_phpunit_types
Sep 27, 2024
Merged
Replace simple-phpunit
with phpunit
#31
alexander-schranz
merged 4 commits into
massiveart:0.5
from
mamazu:fixing_phpunit_types
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0b7323
to
f33f615
Compare
composer.json
Outdated
@@ -17,8 +17,9 @@ | |||
"symfony/framework-bundle": "^4.3 || ^5.0 || ^6.0 || ^7.0" | |||
}, | |||
"require-dev": { | |||
"symfony/phpunit-bridge": "^5.4.33|^6.3.10|^7.0.1", | |||
"matthiasnoback/symfony-dependency-injection-test": "^4.0 || ^5.0" | |||
"phpunit/phpunit": "^9.6.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need 8.5 also for lowest support see https://github.com/sulu/SuluFormBundle/pull/391/files
800e255
to
a9261c7
Compare
That was easy. :D |
a9261c7
to
6d84f55
Compare
simple-phpunit
with phpunit
alexander-schranz
approved these changes
Sep 27, 2024
simple-phpunit
with phpunit
simple-phpunit
with phpunit
@mamazu Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phpunit requires a void return type on the
setUp
method