Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where screen height contained status bar in android #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed an issue where screen height contained status bar in android #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
// packages
import { Dimensions, PixelRatio } from 'react-native';
import { Dimensions, PixelRatio, StatusBar, Platform } from 'react-native';

// Retrieve initial screen's width
let screenWidth = Dimensions.get('window').width;

// Retrieve initial screen's height
let screenHeight = Dimensions.get('window').height;

if(Platform.OS === "android"){
screenHeight -= (StatusBar.currentHeight || 0);
}

/**
* Converts provided width percentage to independent pixel (dp).
* @param {string} widthPercent The percentage of screen's width that UI element should cover
Expand Down Expand Up @@ -38,7 +42,7 @@ const heightPercentageToDP = heightPercent => {
};

/**
* Event listener function that detects orientation change (every time it occurs) and triggers
* Event listener function that detects orientation change (every time it occurs) and triggers
* screen rerendering. It does that, by changing the state of the screen where the function is
* called. State changing occurs for a new state variable with the name 'orientation' that will
* always hold the current value of the orientation after the 1st orientation change.
Expand Down