Fixes #176

[BradyPlanden]

This PR downgrades faer to 0.21.9 with an aligned faer-trait version. In addition, a macos-13 x86 runner is added to the Github CI.

[mhovd]

In #182, I am suggesting bumping faer, rather than downgrading it.

In very good news, faer is back in active development, but has moved from GitHub to Codeberg.

Could you check if the latest version solves the performance regression?

[BradyPlanden]

Thanks @mhovd — yes unfortunately this patch won't solve the problem; however, the most recent release of private-gemm-x86 does. I'm going to update this PR so the macOS Intel support is added to the CI and we can aim to merge it post #182.

[martinjrobins]

@BradyPlanden, now that #182 is merged are you happy to finish this off?

[BradyPlanden]

Brill, yep I'll take another look at this

[BradyPlanden]

I think this should be good @martinjrobins, it's difficult to test with each commit requiring approval so 🤞

[martinjrobins]

I think this should be good @martinjrobins, it's difficult to test with each commit requiring approval so 🤞

yea, its a pain at first having to get the approval, but once you've got a commit in diffsol this will go away

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.94%. Comparing base (dbee867) to head (ec9f197).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   73.94%   73.94%           
=======================================
  Files          84       84           
  Lines        8924     8924           
=======================================
  Hits         6599     6599           
  Misses       2325     2325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[martinjrobins]

the current error is due to the neural ode example bringing in ort, which fails to build:

error: failed to run custom build command for `ort-sys v2.0.0-rc.9`

I don't mind if this example is not tested on intel macs so feel free to turn it off if there is no easy fix