Fix pylint R1716 warnings

martinholmer · Jan 3, 2025 · f304797 · f304797
1 parent 3cb2bbe
commit f304797
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/guide/make/make_uguide.py b/docs/guide/make/make_uguide.py
@@ -9,9 +9,9 @@
 
 import os
 import sys
-# Other scripts in this folder.
-from .make_params import make_params
-from .make_io_vars import make_io_vars
+# Other scripts in this folder:
+from make_params import make_params
+from make_io_vars import make_io_vars
 
 CURDIR_PATH = os.path.abspath(os.path.dirname(__file__))
 

diff --git a/taxcalc/calcfunctions.py b/taxcalc/calcfunctions.py
@@ -2759,7 +2759,7 @@ def PersonalTaxCredit(MARS, c00100, XTOT, nu18,
     if c00100 < RRC_ps[MARS - 1]:
         recovery_rebate_credit = RRC_c * XTOT
         recovery_rebate_credit += RRC_c_unit[MARS-1] + RRC_c_kids * nu18
-    elif c00100 < RRC_pe[MARS - 1] and c00100 > 0:
+    elif 0 < c00100 < RRC_pe[MARS - 1]:
         prt = (
             (c00100 - RRC_ps[MARS - 1]) /
             (RRC_pe[MARS - 1] - RRC_ps[MARS - 1])

diff --git a/taxcalc/growfactors.py b/taxcalc/growfactors.py
@@ -165,6 +165,6 @@ def update(self, name, year, diff):
             msg = 'cannot update growfactors after they have been used'
             raise ValueError(msg)
         assert name in GrowFactors.VALID_NAMES
-        if year >= self.first_year and year <= self.last_year:
+        if self.first_year <= year <= self.last_year:
             assert isinstance(diff, float)
             self.gfdf.loc[year, name] += diff