Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load maps from streams and xdocuments. #33

Merged
merged 2 commits into from
Oct 9, 2016

Conversation

ShawnCowles
Copy link
Contributor

Addresses issue #32 by exposing constructors for creating a map from a stream or an XDocument loaded directly.

The seemingly unrelated change to TiledCore is due to ReadXml not always being called now, so we need a non-null TmxDirectory.

@marshallward marshallward merged commit db357db into marshallward:master Oct 9, 2016
@marshallward
Copy link
Owner

Thanks, this looks great, I will merge it.

@marshallward
Copy link
Owner

Sorry, I may have merged this prematurely. The first commit (iostream) is working fine, but I'm getting some sort of assembly error from the XDocument constructur when I do new TmxMap("some_map.tmx"):

/home/marshall/src/Tesserae/src/Mosaic.cs(19,19): Error CS0012: The type System.Xml.IXmlLineInfo' is defined in an assembly that is not referenced. Consider adding a reference to assemblySystem.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' (CS0012) (Tesserae)

Do you know what this could be? (I will roll back to pre-pull request just to be safe).

@marshallward
Copy link
Owner

(Also I cocked up the revert a bit, so this may be need to be re-submitted)

@ShawnCowles
Copy link
Contributor Author

Strange, nothing in that second commit references any new libraries. Any chance that it's something in the project you're using to test?

@marshallward
Copy link
Owner

Yeah that's a strong possibility. I'll try to work out if it's something on my end.

@LaylBongers
Copy link

Given that this change alters no references, the issue can't be caused by it.

@marshallward
Copy link
Owner

I agree this is almost certainly on my end, I'm just looking through it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants