Merge pull request flask-restful#41 from frankstratton/master

action='append' should always return a list
marrybird · Jan 23, 2013 · 9fea45d · 9fea45d
2 parents c2d78f8 + 89febd6
commit 9fea45d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/flask_restful/reqparse.py b/flask_restful/reqparse.py
@@ -122,6 +122,9 @@ def parse(self, request):
         if not results:
             return self.default
 
+        if self.action == 'append':
+            return results
+
         if self.action == 'store' or len(results) == 1:
             return results[0]
         return results

diff --git a/tests/test_reqparse.py b/tests/test_reqparse.py
@@ -238,6 +238,15 @@ def test_parse_append(self):
         args = parser.parse_args(req)
         self.assertEquals(args['foo'], ["bar", "bat"])
 
+    def test_parse_append_single(self):
+        req = Request.from_values("/bubble?foo=bar")
+
+        parser = RequestParser()
+        parser.add_argument("foo", action="append"),
+
+        args = parser.parse_args(req)
+        self.assertEquals(args['foo'], ["bar"])
+
 
     def test_parse_dest(self):
         req = Request.from_values("/bubble?foo=bar")
@@ -300,7 +309,7 @@ def test_parse_lte_gte_append(self):
         parser.add_argument("foo", operators=["<=", "="], action="append")
 
         args = parser.parse_args(Request.from_values("/bubble?foo<=bar"))
-        self.assertEquals(args['foo'], "bar")
+        self.assertEquals(args['foo'], ["bar"])
 
 
     def test_parse_lte_gte_missing(self):