GROVE-334 : adds 'show more' link to show more facets in the Vue template #8
Conversation
|
This looks good to @withjam, @dalaidunc, and me. Waiting for final review from @grtjn when he's back from holiday before it is merged. |
|
Again, based off of master, and it looks like similar-query changes are mixed in too. Makes review a little harder. I think we would eventually want to move some of this logic into middle-tier, but it is an improvement over what we have now. Let me try to run a quick sanity check, just to make sure all is complete, and i'll merge after that. |
|
|
||
| getValues(name, params, options, searchState, qtext, facetObject) { | ||
| //get options | ||
| return fetch('/v1/config/query/all?format=json', { |
There was a problem hiding this comment.
This should make a call to /search/{type}/config.. (see comments in grove-node PR)
| text: path, | ||
| ns: '' | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think it is better to just copy the entire range object from the constraint. Might not be string, might not be path index..
| ns: '' | ||
| } | ||
| }, | ||
| 'values-option' : ['frequency-order'] |
There was a problem hiding this comment.
copy these from facet-options.. some facets use item-order for sure..
| 'values-option' : ['frequency-order'] | ||
| }; | ||
| //combine with search | ||
| let searchType = 'all'; |
There was a problem hiding this comment.
searchType should be provided as param, like in searchApi..
| }); | ||
|
|
||
| return temp; | ||
| }); |
There was a problem hiding this comment.
I think latest searchApi in development branch has captured this in a helper function that you could expose and reuse here..
| // let searchType = searchType !== undefined ? searchType : 'all'; | ||
| let start = facetObject.facetValues.length +1 || 1; | ||
| // let start = 1; | ||
| let pageLength = 10; |
There was a problem hiding this comment.
how about using facet limit as page-length?
| valuesParams.append('start', start); | ||
| valuesParams.append('pageLength', pageLength); | ||
| valuesParams.append('limit', limit); | ||
| valuesParams.append('direction', 'descending'); |
There was a problem hiding this comment.
direction should match direction of facet..
| valuesParams.append('direction', 'descending'); | ||
| let valuesParamsString = valuesParams.toString(); | ||
|
|
||
| return fetch('/v1/values/' + name + '?'+valuesParamsString, { |
There was a problem hiding this comment.
similar to getting of config, make a call to /search/{type}/values instead. Consider passing above params through via post body rather than request params, and rewrite them in middle-tier to request params, though perhaps something for bonus..
| showMore(facet, facetName) { | ||
| if (facet.displayingAll) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this should be unnecessary I think. the button should simply not show if displayingAll is true..
3 participants
No description provided.