Skip to content

Fix: fix client sse tcp connection re-use by draining outstanding io #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix: fix client sse tcp connection re-use by draining outstanding io #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions client/transport/sse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,19 @@ func (c *SSE) SendRequest(
deleteResponseChan()
return nil, fmt.Errorf("failed to send request: %w", err)
}
defer resp.Body.Close()

// Drain any outstanding io
body, err := io.ReadAll(resp.Body)
resp.Body.Close()

if err != nil {
return nil, fmt.Errorf("failed to read response body: %w", err)
}

// Check if we got an error response
if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusAccepted {
deleteResponseChan()

body, _ := io.ReadAll(resp.Body)
return nil, fmt.Errorf("request failed with status %d: %s", resp.StatusCode, body)
}

Expand Down