fix: prevent SSEServer.Start() from overriding http server

[chr0n1x]

s.srv can be set via WithHTTPServer. so if we end up using WithHTTPServer and then invoke Start, s.srv will be overwritten

Summary by CodeRabbit

• Bug Fixes
  • Improved the server's startup process to ensure a single, stable initialization, preventing issues when starting the service multiple times.

[coderabbitai]

Walkthrough

This pull request updates the Start method in the SSEServer class by adding a conditional check to ensure that the HTTP server instance is only initialized when it is nil. This prevents the accidental overwriting of the server instance if Start is invoked multiple times. The method continues to call and return s.srv.ListenAndServe() as before, and there are no changes to the exported or public entities.

Changes

File	Change Summary
server/sse.go	Modified the Start method: added a conditional check to initialize the HTTP server instance only when nil.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0e968a and ef0ce2f.

📒 Files selected for processing (1)

• server/sse.go (1 hunks)

🔇 Additional comments (1)

server/sse.go (1)

173-178: Good fix to prevent overriding the HTTP server!

This change correctly implements a conditional check to only initialize a new HTTP server when s.srv is nil. This ensures that any server previously set through the WithHTTPServer option is preserved, preventing accidental overwrites when Start is called multiple times.

The change is aligned with the PR objective and maintains proper behavior for both scenarios - when a custom server is provided and when using the default server configuration.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jkwang-a]

@chr0n1x
Hello, did you write your sse service yourself? Can Cursor link successfully?

I use the example of the official website, Cursor has not been linked, but postmain can be linked, do you know what the reason?

https://github.com/mark3labs/mcp-go/blob/main/examples/everything/main.go

help!

[chr0n1x]

@jkwang-a yes I wrote my own server using this lib.

I think it needs to be port 80 though? do you have something else running on port 8080?