Skip to content

Fix two issues #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two issues #124

wants to merge 2 commits into from

Conversation

@aleen42
Copy link

@aleen42 aleen42 commented Jul 9, 2021 •
edited
Loading

REF: 4458bc7#r53250238

@marioizquierdo There are two problems:

  1. Cannot assume that getCheckboxUncheckedValue returns a string value, which should throw an exception when it is not a string by calling val.replace(rCRLF, '\r\n').
  2. radio is not a checkbox, and it has broken when we want to only set unchecked value for input[type=checkbox]

aleen42 referenced this pull request Jul 9, 2021
@marioizquierdo
Integrate readCheckboxUncheckedValues into the new serializeArray met…
4458bc7 
…hod to simplify the serialization process for unchecked checkboxes
@aleen42
Copy link
Author

aleen42 commented Jul 30, 2021

any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aleen42