Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional selection modes #3725

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nojaf
Copy link

@nojaf nojaf commented Feb 8, 2025

📝 Summary

Fixes #3624

🔍 Description of Changes

This is a WIP, but I started with adding the new selection modes to both the JavaScript and Python side.

I still need to to the actual implementation, but since I'm new to this project I could benefit from some early feedback.

Open questions:

  • Where should the checkbox in the cell be positioned? What do you folks have in mind here UI-wise?
  • Should initial_selection be taking into account here? Or would that remain row specific?

📋 Checklist

📜 Reviewers

@mscolnick

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:29am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:29am

Copy link

github-actions bot commented Feb 8, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nojaf
Copy link
Author

nojaf commented Feb 8, 2025

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propogate column information when cell selected in mo.ui.Table
1 participant