CONC-766: Disable clang -Wcast-function-type-strict for makecontext

[grooverdan]

makecontext has a defined prototype in ucontext.h that differs from its expected usage. Disable the clang warning for this function call.

Modelled off the af4498b commit.

[knielsen]

The patch is ok.

An alternative might be to build with cmake arg -DWITH_BOOST_CONTEXT=ON. Then it will not try to use ucontext, even in address sanitizer build.

You might want to also remove this comment earlier in the file. Someone "Tildeslash" changed the code to remove the original fix for this function type mismatch without even bothering to fix (or even read?) the comment :-( :

/*
  We use old-style function definition here, as this is passed to
  makecontext(). And the type of the makecontext() argument does not match
  the actual type (as the actual type can differ from call to call).
*/

[grooverdan]

The patch is ok.

Thank you.

An alternative might be to build with cmake arg -DWITH_BOOST_CONTEXT=ON. Then it will not try to use ucontext, even in address sanitizer build.

Rather stick to testing as close the code that is released as possible.

You might want to also remove this comment earlier in the file. Someone "Tildeslash" changed the code to remove the original fix for this function type mismatch without even bothering to fix (or even read?) the comment :-( :

/*
  We use old-style function definition here, as this is passed to
  makecontext(). And the type of the makecontext() argument does not match
  the actual type (as the actual type can differ from call to call).
*/

So belatedly maybe:

/*
   Note, the prototype of makecontext doesn't match the calling convention as
   the types of arguments can differ from call to call. Because of this, the warning 
  `Wcast-function-type-strict` is disabled below around setting up the callback to
  this function.
*/