fix: preserve loadFile transaction errors - #315
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
Give importSqlFile one transaction-finalization path, retain failing command context, and append rollback failures without masking the primary cause. Closes margelo#308.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importSqlFile()one transaction-finalization scope instead of rolling back in nested catchesBEGINand before a successfulCOMMITThe regression is registered only on iOS because its fixture path is supplied from the bundled iOS example resource. The production fix is shared C++ and was also compiled through the Android app build.
Verification
Could not load file:context:app:assembleDebugforarm64-v8a: succeededbun typecheck(all three workspaces)git diff --checkCloses #308.