fix(android): align nitro-fetch NDK version - #179
Conversation
|
@huytdps13400 is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
|
Yeah thanks. Ideally this should be fixed by RN itself. I have an issue opened there. But this works for now |
|
That makes sense. This keeps nitro-fetch aligned with the consuming React Native project's selected NDK in the meantime, and can be revisited once the upstream RN/AGP behavior guarantees that alignment for libraries. I'll keep an eye on the upstream issue and adjust this PR if you prefer a different interim approach. |
|
Ideally RN should never use NDK 27 with AGP 9. The default version is NDK 28 |
|
Agreed. The merged change does not pin NDK 27; it delegates to the consuming root project’s |
Summary
react-native-nitro-fetchAndroid library with the consuming root project'sndkVersionNitroFetch_ndkVersionpackage property when the root does not override itFixes #178.
Verification
The same Gradle model probe was run before and after the change:
Additional checks:
bun test— 10 passed, 2 existing TODOsbun typecheckbun lint— no errors (2 existing no-shadow warnings in unrelated Expo plugin files)./gradlew :react-native-nitro-fetch:assembleDebug -PreactNativeArchitectures=arm64-v8a— successful27.1.12297006llvm-readelf -Ws libnitrofetch.socontains no__cxa_init_primary_exceptionreference