Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow cookie options like: secure, samesite etc #316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow cookie options like: secure, samesite etc #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d76ef3
allow cookie options
feger0 Aug 17, 2020
aef9ac7
fixed indents
feger0 Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/store-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = {
var storeAPI = {
version: '2.0.12',
enabled: false,

// get returns the value of the given key. If that value
// is undefined, it returns optionalDefaultValue instead.
get: function(key, optionalDefaultValue) {
Expand All @@ -25,11 +25,11 @@ var storeAPI = {

// set will store the given value at key and returns value.
// Calling set with value === undefined is equivalent to calling remove.
set: function(key, value) {
set: function(key, value, options) {
if (value === undefined) {
return this.remove(key)
}
this.storage.write(this._namespacePrefix + key, this._serialize(value))
this.storage.write(this._namespacePrefix + key, this._serialize(value), options)
return value
},

Expand Down Expand Up @@ -66,11 +66,11 @@ var storeAPI = {
createStore: function() {
return createStore.apply(this, arguments)
},

addPlugin: function(plugin) {
this._addPlugin(plugin)
},

namespace: function(namespace) {
return createStore(this.storage, this.plugins, namespace)
}
Expand Down Expand Up @@ -100,7 +100,7 @@ function createStore(storages, plugins, namespace) {
if (!legalNamespaces.test(namespace)) {
throw new Error('store.js namespaces can only have alphanumerics + underscores and dashes')
}

var _privateStoreProps = {
_namespacePrefix: namespacePrefix,
_namespaceRegexp: namespaceRegexp,
Expand Down Expand Up @@ -158,7 +158,7 @@ function createStore(storages, plugins, namespace) {

return (val !== undefined ? val : defaultVal)
},

_addStorage: function(storage) {
if (this.enabled) { return }
if (this._testStorage(storage)) {
Expand Down Expand Up @@ -207,10 +207,10 @@ function createStore(storages, plugins, namespace) {
self._assignPluginFnProp(pluginFnProp, propName)
})
},

// Put deprecated properties in the private API, so as to not expose it to accidential
// discovery through inspection of the store object.

// Deprecated: addStorage
addStorage: function(storage) {
_warn('store.addStorage(storage) is deprecated. Use createStore([storages])')
Expand All @@ -224,7 +224,7 @@ function createStore(storages, plugins, namespace) {
store.raw = {}
each(store, function(prop, propName) {
if (isFunction(prop)) {
store.raw[propName] = bind(store, prop)
store.raw[propName] = bind(store, prop)
}
})
each(storages, function(storage) {
Expand Down
5 changes: 3 additions & 2 deletions storages/cookieStorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ function each(callback) {
}
}

function write(key, data) {
function write(key, data, options) {
if(!key) { return }
doc.cookie = escape(key) + "=" + escape(data) + "; expires=Tue, 19 Jan 2038 03:14:07 GMT; path=/"
var opts = options ? options : ""
doc.cookie = escape(key) + "=" + escape(data) + "; expires=Tue, 19 Jan 2038 03:14:07 GMT; path=/" + opts
}

function remove(key) {
Expand Down