feat: add performance regression detection system#118
Open
Conversation
- cmd/sidecar/main.go: Handle os.Unsetenv error with blank identifier - internal/adapter/amp/adapter_test.go: Handle os.MkdirAll errors in test helpers - internal/adapter/kiro/kiro_test.go: Handle os.MkdirAll and os.WriteFile errors - internal/plugins/workspace/diff_test.go: Handle exec.Cmd.Run and os.WriteFile errors - internal/plugins/conversations/view_content.go: Fix ineffassign by using var declaration All 24 linting errors (23 errcheck + 1 ineffassign) now resolved. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Implement automated performance regression detection with: - Baseline benchmark metrics (.benchmarks/baseline.json) - Regression detector tool (perf-regressor.go) that compares current benchmarks against baseline and detects >10% performance degradation - CI integration script (ci-benchmark-check.sh) for automated regression testing - GitHub Actions workflow for running benchmarks on PRs - Comprehensive documentation (REGRESSION.md) on performance targets and workflow Performance thresholds: - ClaudeCode adapter: 1MB parse <50ms, 10MB parse <500ms, cache <1ms - Codex adapter: session walk <100ms, metadata parse <10ms The system captures baseline metrics from existing benchmarks, stores metrics, and fails builds if critical performance thresholds are exceeded. PR checks automatically compare against main branch baseline and comment with results. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement automated performance regression detection for Sidecar. The system captures baseline benchmarks from the existing benchmark suite (ClaudeCode and Codex adapters), stores metrics, and detects when changes cause >10% performance degradation.
Key features:
Changes
New Files
.benchmarks/baseline.json- Performance baseline metricsscripts/perf-regressor.go- Regression detection tool (507 LOC)scripts/benchmark-baseline.sh- Baseline capture scriptscripts/ci-benchmark-check.sh- CI integration scriptscripts/BENCHMARK_README.md- Scripts documentationREGRESSION.md- System documentation.github/workflows/benchmark.yml- GitHub Actions workflowModified Files
.gitignore- Exclude benchmark artifactsPerformance Targets
ClaudeCode Adapter:
Codex Adapter:
Test Plan
🤖 Generated with Claude Code