-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat(schema): allow set _ignore_default_error to True #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ah, deploy preview CI step is broken 🤔 |
Thanks for the PR. I can be a good idea but we need to fix this in a different way. In the AvroSchema.init method you can get the extra The |
marcosschroh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the property in the AvroSchema.init _ignore_default_error and use it when creating the schema.
c44ae11 to
4d19c3f
Compare
|
Hi again, thanks for reviewing this PR. |
087a8a3 to
bcd4e4a
Compare
|
Added tests! 🎉 |
_ignore_default_error will ignore errors like:
"Default value must match first schema in union with type: null"
...which I agree are errors but are painful to fix when backporting stuff.
WDYT?