replacing deprecated methods per analyzer warning notes #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It appears that the Apple header incorrectly describes asl_next() and asl_release() being available in iOS 7.0. They are not defined in the 7.0 SDK header (/usr/include/asl.h). I'll update this PR with an additional compile and run-time check. |
The deprecation attribute incorrectly states that the replacement methods, asl_next()/asl_release(), are available in __IPHONE_7_0; however, they first appear in __IPHONE_8_0. This would require both a compile and runtime check to properly implement the new methods while the minimum deployment target for this project remains iOS 7.0.
Contributor
Author
|
I've reverted to the deprecated methods but silence the warning, along with a lengthy comment about the issue to alert the future us' about why it was done. |
Nellyjay22
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static analyzer was complaining about aslresponse_next() and aslresponse_free(); the deprecation comments point out appropriate replacements, which I've substituted here.