Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style json in MLNMapView #3240

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add style json in MLNMapView #3240

wants to merge 8 commits into from
+183 −3

Conversation

wangyingfang
Copy link
Collaborator

@github-actions GitHub Actions
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +1.15Ki  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3240-compared-to-main.txt

random3940
random3940 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@random3940 random3940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that it's the same API as we have on Android - LGTM.

@louwers louwers self-requested a review February 22, 2025 19:04
@wangyingfang
Copy link
Collaborator Author

@louwers please help review and re-run the pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers left review comments

@random3940 random3940 random3940 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangyingfang @louwers @random3940