Custom drawable layer v3

[adrian-cojocaru]

Update for CustomDrawableLayer interface and existing example.

• added removeDrawable for existing drawables (currently the only way to update vertex geometry is to remove and re-add the drawable)
• added tweaker callbacks that can update drawable properties/options
• added setGeometryOptions/addGeometry for uploading externally generated geometry (example generateGeometry and loadGeometry using tinyobjloader)
• updated CustomDrawableLayer tweakers to work with consolidated UBOs
• added an example to the glfw sample (tested with all rendering backends)
• fixed Remove macros Vulkan shader definitions #3203

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%  +352Ki  +0.2% +78.1Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3210-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +32% +36.5Mi  +439% +26.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3210-compared-to-legacy.txt

[github-actions]

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0078         -0.0083             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3210-compared-to-main.txt

[sjg-wdw]

I like the changes to the Custom Drawable interface and the example. How did you end up feeling about the OBJ reader?

[adrian-cojocaru]

In the example the OBJ reader ended up being used with a sphere and it's mostly just a proof of concept. It can be extended later to use vertex color and normals from the file.

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +31.9Ki  +0.1% +16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3210-compared-to-main.txt

[louwers]

Would you mind adding a note to the Developer Docs in docs/mdbook with a screenshot and a few words, just to make people know this exists?

You can drag the screenshot in any GitHub comment so we let GitHub host it for us.

Maybe in a separate PR if you would just like to get this merged first?

[louwers]

I get a crash with Metal when built via Bazel...?

bazel run //platform/glfw:glfw_app  --//:renderer=metal -- --style https://demotiles.maplibre.org/style.json 

[adrian-cojocaru]

Would you mind adding a note to the Developer Docs in docs/mdbook with a screenshot and a few words, just to make people know this exists?

You can drag the screenshot in any GitHub comment so we let GitHub host it for us.

Maybe in a separate PR if you would just like to get this merged first?

I can add the motivation behind it and the intended usage (would prefer a different PR but it's ok either way).

I get a crash with Metal when built via Bazel...?

bazel run //platform/glfw:glfw_app  --//:renderer=metal -- --style https://demotiles.maplibre.org/style.json 

If it's an exception when enabling the custom drawable layer (KEY_V) then it's related to some issue that doesn't add the resources in platform/glfw/assets to the build. Enabling the location indicator (KEY_G) triggers the same exception.
If it's anything else can you provide a callstack?