Fix incorrect Object/function checking in node index.js wrapper #3177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node
Fix incorrect Object/function checking in node index.js wrapper.
Changes
options instanceof Object
bytypeof options === "object"
options.request instanceof Function
bytypeof options.request === "function"
Using
instanceof Object
can be problematic because it won't work correctly for all objects.E.g. the following object
{ ratio: 1, request: [Function: request] }
returnsoptions instanceof Object
false
and at the same timetypeof options.request === "function"
true
. Simillar to the function check.Other changes
let
andconst
instead ofvar
to prevent hoisting issuesif (options...
every time, use nested if