Skip to content

Lazy-load properties upon first getProperties() call #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Lazy-load properties upon first getProperties() call #53

wants to merge 18 commits into from

Conversation

@brunoabinader
Copy link
Member

@brunoabinader brunoabinader commented Nov 30, 2018 •
edited
Loading

Given that the data source for generating the properties map doesn't change after the feature object is instantiated, this PR:

  • Generate properties map upon first call, then store it for further getProperties() calls
  • Return properties using pass-by-const-ref to avoid extra copies
  • Use getProperties() logic in getValue()

kkaefer and others added 18 commits June 2, 2017 15:02
@kkaefer
interpret missing field in vector tile values as null instead of false
6e73ea9
@kkaefer
parse all fields in a value message rather than just the first one
29e46f3
@flippmoke
Prevented the creation of very massive vectors based on invalid comma…
b12e109 
…nd counts
@flippmoke
Make limit constexpr
a395f9c
@flippmoke
Effectively force all close_path commands to be treated as if th they…
2b7d952 
… had a command count of 1
@flippmoke
Added shrink to fit for incorrect lengths even with 1mb to prevent re…
cc2f748 
…peated uses of this tactic to allocate and leave multiple vectors, shifted max reserve from 10mb to 1mb.
@flippmoke
Fix typo in comment
33ace75
@flippmoke
Merge pull request #30 from mapbox/limit_reserve
f0d5727 
Prevent Massive Over Allocation
@flippmoke
Merge pull request #16 from mapbox/vector-tile-value-null
b8d55d3 
Align property parsing with JS implementation
@flippmoke
Bump to 1.0.0
97cf4e7
@flippmoke
Fix failing unit test after bump
6e70d68
@flippmoke
It is currently possible to have an overflow or underflow in our x or…
d3de5d2 
… y position if multiple int32_t deltas push a value outside of the max range of an int32_t. This change bumps the x and y values to int64_t. It is still possible to have an overflow or underflow, however, this is much less likely and would require a large number of large deltas to reach this point.
@flippmoke
Merge pull request #33 from mapbox/prevent_overflow
170c83a 
Preventing Overflows and Underflows on Points
@flippmoke
Bump to v1.0.1
8aa13db
@nagineni
Fix compilation errors with libc++ on QNX 7
7c0e2fc 
It seems that the QNX 7 compiler (i.e qcc based on GCC 5.4.0 with
libc++ from LLVM) has a limited c++11 feature support and causing
compilation errors with the inheriting constructors. This patch
fixes the issues by providing the universal forwarding constructor.
Also, resolves an ambiguous overload error with optional<T>.
@nagineni
Bump to v1.0.2
d46ae61
@brunoabinader
Support for geometry v1.0.0
5084dba
@brunoabinader
Lazy-load properties upon first getProperties() call
995a2c2
@brunoabinader brunoabinader self-assigned this Nov 30, 2018
@brunoabinader brunoabinader mentioned this pull request Nov 30, 2018
Closed
@xabbu42 xabbu42 mentioned this pull request Jan 21, 2019
Closed
@kkaefer kkaefer removed their request for review January 4, 2021 10:47
@xabbu42 xabbu42 mentioned this pull request Feb 12, 2023
Closed
@nathreed nathreed mentioned this pull request May 20, 2024
Closed
@nathreed nathreed mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@springmeyer springmeyer Awaiting requested review from springmeyer

@tmpsantos tmpsantos Awaiting requested review from tmpsantos

At least 1 approving review is required to merge this pull request.

Assignees

@brunoabinader brunoabinader

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brunoabinader @kkaefer @flippmoke @nagineni