Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add a Datasets class and tests #27

Closed
wants to merge 8 commits into from
Closed

Add a Datasets class and tests #27

wants to merge 8 commits into from

Conversation

sgillies
Copy link
Contributor

Also move other classes to submodules.

Very preliminary.

sgillies and others added 3 commits September 19, 2015 09:06
Also move other classes to submodules.
We might want to consider 3 levels of commands for mbx:

  mbx [api] [command]

which would be

  mbx datasets list [owner]
  mbx datasets create [owner]
  mbx datasets get [owner] [id]
@sgillies
Copy link
Contributor Author

Thanks for getting me straightened out with tokens, @emilymcafee @willwhite! I'm in your API, fetching all the features.

$ mbx features sgillies 0b87ffb3 > 0b87ffb3.json

ls_datasets, create_dataset, retrieve_features, and update_features.
None of these names are decided and will probably be changed.
@sgillies
Copy link
Contributor Author

Demo of round-tripping features from rio-shapes through the Dataset API: https://gist.github.com/sgillies/369b580df78839d15c46.

@sgillies
Copy link
Contributor Author

All caught up with master. I'm still uncertain about the names of the CLI commands and API methods.

@willwhite
Copy link

What about them @sgillies ?

@sgillies
Copy link
Contributor Author

@willwhite I'm just debating with myself over stuff like retrieve_feature(id) vs get_feature(id) vs feature(id) and update_feature(id, val) vs set_feature(id, val) vs feature(id, val). Trying to come up with something close to the ideal fit for Python on the first try :)

@sgillies sgillies mentioned this pull request Oct 27, 2015
@perrygeo
Copy link
Contributor

Heads up: Create dataset should return 201

@sgillies sgillies added this to the post-oh-point-three milestone Nov 10, 2015
@perrygeo perrygeo mentioned this pull request Dec 3, 2015
@sgillies
Copy link
Contributor Author

sgillies commented Dec 3, 2015

Closing. Related work continues in #80.

@sgillies sgillies closed this Dec 3, 2015
@sgillies sgillies modified the milestones: post-oh-point-three, 0.5 Dec 8, 2015
@sgillies sgillies deleted the dataset-datasets branch May 9, 2018 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants