Skip to content

Support for new route properties; Add BRITISH_IMPERIAL voice unit #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2025

Conversation

DzmitryFomchyn
Copy link
Contributor

@DzmitryFomchyn DzmitryFomchyn commented Apr 18, 2025

Added support for:

  • StepIntersection#formOfWay,
  • StepIntersection#geometries
  • StepIntersection#access
  • StepIntersection#elevated
  • StepIntersection#bridge

Also added a new voice unit value: DirectionsCriteria#BRITISH_IMPERIAL.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.06%. Comparing base (7364adf) to head (5b7f61c).
⚠️ Report is 1 commits behind head on main.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1611      +/-   ##
============================================
+ Coverage     78.03%   78.06%   +0.03%     
  Complexity     1062     1062              
============================================
  Files           159      159              
  Lines          4479     4486       +7     
  Branches        626      626              
============================================
+ Hits           3495     3502       +7     
  Misses          715      715              
  Partials        269      269              
Files with missing lines Coverage Δ
.../mapbox/api/directions/v5/models/RouteOptions.java 95.38% <100.00%> (+0.17%) ⬆️
...box/api/directions/v5/models/StepIntersection.java 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DzmitryFomchyn DzmitryFomchyn marked this pull request as ready for review May 7, 2025 13:41
@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner May 7, 2025 13:41
@DzmitryFomchyn DzmitryFomchyn changed the title Support for StepIntersection.formOfWays and StepIntersection.geometries Support for new route properties; Add BRITISH_IMPERIAL voice unit Jul 31, 2025
Copy link
Contributor

@RingerJK RingerJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DzmitryFomchyn DzmitryFomchyn merged commit 6efe143 into main Aug 1, 2025
4 of 5 checks passed
@DzmitryFomchyn DzmitryFomchyn deleted the df-road-attributes branch August 1, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants