-
Notifications
You must be signed in to change notification settings - Fork 120
Support for new route properties; Add BRITISH_IMPERIAL voice unit #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1611 +/- ##
============================================
+ Coverage 78.03% 78.06% +0.03%
Complexity 1062 1062
============================================
Files 159 159
Lines 4479 4486 +7
Branches 626 626
============================================
+ Hits 3495 3502 +7
Misses 715 715
Partials 269 269
🚀 New features to boost your workflow:
|
7bf96fc
to
6772257
Compare
6772257
to
8f999a6
Compare
8f999a6
to
2d0f464
Compare
3939d2e
to
8bb25f3
Compare
maxxporoshin
reviewed
Aug 1, 2025
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java
Outdated
Show resolved
Hide resolved
maxxporoshin
reviewed
Aug 1, 2025
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java
Outdated
Show resolved
Hide resolved
maxxporoshin
reviewed
Aug 1, 2025
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
maxxporoshin
reviewed
Aug 1, 2025
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
maxxporoshin
reviewed
Aug 1, 2025
services-directions-models/src/test/resources/directions_v5_with_toll_costs_and_lanes.json
Show resolved
Hide resolved
maxxporoshin
approved these changes
Aug 1, 2025
RingerJK
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for:
StepIntersection#formOfWay
,StepIntersection#geometries
StepIntersection#access
StepIntersection#elevated
StepIntersection#bridge
Also added a new voice unit value:
DirectionsCriteria#BRITISH_IMPERIAL
.