Skip to content

(Online shop) Sales Item: Updating Stock-level #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

adisa39
Copy link
Collaborator

@adisa39 adisa39 commented Jul 7, 2025

  • Fixed cancel payment callback API endpoint bug.
  • Fixed item sales item price updating bug.
  • limit sales item possible order quantity based on the item stock level.

@swoocn swoocn added the pending-c/o-feedback Awaiting feedback from Code Owner. label Jul 11, 2025
@adisa39
Copy link
Collaborator Author

adisa39 commented Jul 11, 2025

Nice refactoring 👍

@adisa39
Copy link
Collaborator Author

adisa39 commented Jul 12, 2025

It looks good to me. Thanks

@adisa39 adisa39 requested a review from swoocn July 12, 2025 01:11
@swoocn
Copy link
Member

swoocn commented Jul 12, 2025

Hi @adisa39 -
I’ve started testing the feature and came across a few issues. For example, when I purchase an item marked as “1 available,” it still appears in the buyer listing even after it’s been sold. It only disappears once I refresh the buyer screen. Additionally, I noticed that consecutive payments are failing after a successful order, with a “Payment Verification Failed” message. Is this expected, considering your payment-related PRs are not yet fully in place?

Since we’re currently deferring the payment flow until the online ordering feature is complete, I’m unsure how to accurately test the use cases outlined in the requirements document @ https://sharing.clickup.com/9015444408/t/h/86c3275h5/PXUPLHKBSSA69R5. It seems like this task might still be a work in progress, dependent on the final payment structure — or is the expectation that the seller will manually mark the order as completed for the stock levels to change? Hope I'm making sense here.. 🙃

@adisa39
Copy link
Collaborator Author

adisa39 commented Jul 12, 2025

Although the error might be caused from attempting to buy sold stock level, but payment error can be further debugged after the payment queuing is merged.

The sales item refresh error can be handled using React state hook properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-c/o-feedback Awaiting feedback from Code Owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants