(Online shop) Sales Item: Updating Stock-level #408
+46
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adisa39
commented
Jul 7, 2025
adisa39
commented
- Fixed cancel payment callback API endpoint bug.
- Fixed item sales item price updating bug.
- limit sales item possible order quantity based on the item stock level.
adisa39
requested review from
swoocn,
omotoshoayomikun,
amt-fredrick-amoako and
DarinHajou
swoocn
reviewed
Jul 11, 2025
| @@ -130,6 +130,20 @@ export default function OnlineShopping({ dbSeller }: { dbSeller: ISeller }) { | |||
| ); | |||
| }; | |||
|
|
|||
| type ShopeItemType = { | |||
There was a problem hiding this comment.
This can be moved to the types file. Perhaps we could rename this to ShopItemData instead?
There was a problem hiding this comment.
Though it’s only referenced in this single file
swoocn
reviewed
Jul 11, 2025
| case StockLevelType.available_3: | ||
| return 3; | ||
| default: | ||
| return 10000; // Default to 1k if no stock level matches |
There was a problem hiding this comment.
10k should be okay
|
Nice refactoring 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.