Skip to content

revamp the sidebar and implement the filter search #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2025
Merged

Conversation

omotoshoayomikun
Copy link
Collaborator

revamp the sidebar and implement the filter search

@swoocn
Copy link
Member

swoocn commented Feb 24, 2025

Hi @omotoshoayomikun -
I’ve noticed some unusual behavior with the toggling of the filters. Sometimes when one filter is turned off, another one gets activated, and vice versa. My understanding is that there shouldn’t be any dependencies between the filters; each one should toggle independently without affecting others.

Additionally, I tested my store with the filters, turning both applicable filters off, but I can still see my store when I expected not to. It’s a Test Seller with a Trust Meter score of 100%. [See screenshot below]

image

@swoocn swoocn added the pending-c/o-feedback Awaiting feedback from Code Owner. label Feb 24, 2025
@swoocn
Copy link
Member

swoocn commented Mar 19, 2025

FE changes look good after incorporating the translation, @omotoshoayomikun. Great job! 👍

[Current screenshot]

image

Don't suppose you could make a couple UI adjustments?

  1. Keep the 'Search Filters' subheader centered when toggled and the list is expanded. Also, can you center the 'Personalization' subheader when it gets toggled as well?
  2. It would be great if you could keep the filter options on the same line when the sidebar is displayed on smaller viewpoints. Right now, the wording gets wrapped, which affects the display. This will be especially important for translated versions.

Thanks!

1. Keep the 'Search Filters' and Personalization' subheader centered when toggled and the list is expanded.
2. keep the filter options on the same line when the sidebar is displayed on smaller viewpoints
@omotoshoayomikun omotoshoayomikun removed the pending-c/o-feedback Awaiting feedback from Code Owner. label Mar 19, 2025
Copy link
Member

@swoocn swoocn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @omotoshoayomikun! 😎👍
Your FE PR is approved.

@swoocn swoocn merged commit 881d83e into dev Mar 20, 2025
1 check passed
@swoocn swoocn deleted the feature/filter_search branch March 20, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants