-
Notifications
You must be signed in to change notification settings - Fork 6
revamp the sidebar and implement the filter search #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
revamp the sidebar and implement the filter search
Hi @omotoshoayomikun - Additionally, I tested my store with the filters, turning both applicable filters off, but I can still see my store when I expected not to. It’s a Test Seller with a Trust Meter score of 100%. [See screenshot below] |
FE changes look good after incorporating the translation, @omotoshoayomikun. Great job! 👍 [Current screenshot] Don't suppose you could make a couple UI adjustments?
Thanks! |
1. Keep the 'Search Filters' and Personalization' subheader centered when toggled and the list is expanded. 2. keep the filter options on the same line when the sidebar is displayed on smaller viewpoints
…map-of-pi-frontend-react into feature/filter_search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @omotoshoayomikun! 😎👍
Your FE PR is approved.
revamp the sidebar and implement the filter search