Skip to content

Feature/membership UI #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Feature/membership UI #357

wants to merge 6 commits into from

Conversation

DarinHajou
Copy link
Member

This PR introduces the frontend membership feature. It adds a membership screen button to the sidebar, a membership screen to display user details, and routing logic to handle navigation. Membership details like class, expiration, and balance are now accessible, and the user token is included for API authentication.

@swoocn
Copy link
Member

swoocn commented Jan 29, 2025

Hey @DarinHajou - Solid work overall! 👍
Could you please make some refinements to the UX to bring it closer to the expected design? More specifically ->

  • Make the font size bigger; perhaps make it consistent with our existing screens i.e., Seller Registration.
  • Reorder the labels accordingly.

Also, would I expect the member selection dropdown in this PR?
I'm not quite sure how it gets displayed. Perhaps, I am missing something..?

I've taken a screenshot comparison for your convenience. Thx!

image

@swoocn
Copy link
Member

swoocn commented Mar 6, 2025

Could you tell me where you are at with this PR @DarinHajou?
Please note our PM's recent decision @ https://sharing.clickup.com/9015444408/t/h/86c12kbuy/17QFLMKQYI082G8.
Keep me posted; thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants