-
Notifications
You must be signed in to change notification settings - Fork 6
Resolved reported bugs ,pop-up Size consistency and map panning #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @Frankdevlopes - please remember to update your feature branch with the current state of the dev branch before making any updates. There are quite a lot of merge conflicts and it gets challenging to resolve them while maintaining stable code. Thx! |
I will ensure i update it 👍 thanks for the review.
…On Tue, Jan 21, 2025, 00:17 Danny Lee ***@***.***> wrote:
Hi, @Frankdevlopes <https://github.com/Frankdevlopes> - please remember
to update your feature branch with the current state of the dev branch
before making any updates. There are quite a lot of merge conflicts and it
gets challenging to resolve them while maintaining stable code. Thx!
—
Reply to this email directly, view it on GitHub
<#356 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCTOVHI7H6AW3CWA2YX75CD2LVRXNAVCNFSM6AAAAABUUTRU6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBTGI2DAMZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…nnning-consistency; attempt to resolve merge conflicts.
Hey @Frankdevlopes - I just want to double-check in case I missed anything, as the seller popup still appears inconsistent, and the dimensions don't appear to be fixed according to the requirements. Please refer to the screenshot below -> |
You are right @swoocn it is not supposed to have inconsistent dimensions there is a problem since in my local environment it had defined dimensions i will check on it by today |
Please let me know when you update the PR. Thanks @Frankdevlopes! |
Hi - @Frankdevlopes I think just maxHeight and maxWidth for both the image and the tag body can fix this. Tnx |
[BUMP] Any progress on this @Frankdevlopes? |
PR superseded by #385. |
-Added fixed dimension to the seller image to avoid distortion of the pop-up
-modified handleclick function pan the map so as to center the pop up
-ensured seller.name only wraps twice and reduced it's fontsize to 16px