Skip to content

Resolved reported bugs ,pop-up Size consistency and map panning #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Frankdevlopes
Copy link
Collaborator

-Added fixed dimension to the seller image to avoid distortion of the pop-up
-modified handleclick function pan the map so as to center the pop up
-ensured seller.name only wraps twice and reduced it's fontsize to 16px

@swoocn
Copy link
Member

swoocn commented Jan 20, 2025

Hi, @Frankdevlopes - please remember to update your feature branch with the current state of the dev branch before making any updates. There are quite a lot of merge conflicts and it gets challenging to resolve them while maintaining stable code. Thx!

@Frankdevlopes
Copy link
Collaborator Author

Frankdevlopes commented Jan 20, 2025 via email

…nnning-consistency; attempt to resolve merge conflicts.
@swoocn
Copy link
Member

swoocn commented Jan 21, 2025

Hey @Frankdevlopes -
Could you please review and validate the latest push to your PR after the merge conflict resolution to confirm everything looks as expected based on your changes?

I just want to double-check in case I missed anything, as the seller popup still appears inconsistent, and the dimensions don't appear to be fixed according to the requirements. Please refer to the screenshot below ->

image

@Frankdevlopes
Copy link
Collaborator Author

You are right @swoocn it is not supposed to have inconsistent dimensions there is a problem since in my local environment it had defined dimensions i will check on it by today

@swoocn
Copy link
Member

swoocn commented Jan 26, 2025

You are right @swoocn it is not supposed to have inconsistent dimensions there is a problem since in my local environment it had defined dimensions i will check on it by today

Please let me know when you update the PR. Thanks @Frankdevlopes!

@adisa39
Copy link
Collaborator

adisa39 commented Jan 26, 2025

Hi - @Frankdevlopes I think just maxHeight and maxWidth for both the image and the tag body can fix this. Tnx

@swoocn
Copy link
Member

swoocn commented Mar 6, 2025

You are right @swoocn it is not supposed to have inconsistent dimensions there is a problem since in my local environment it had defined dimensions i will check on it by today

Please let me know when you update the PR. Thanks @Frankdevlopes!

[BUMP] Any progress on this @Frankdevlopes?

@swoocn
Copy link
Member

swoocn commented Apr 16, 2025

PR superseded by #385.

@swoocn swoocn closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants