Online shop/membership #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mappi allowance
adisa39
requested review from
swoocn,
omotoshoayomikun,
soleil00,
DarinHajou and
Frankdevlopes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… without membership
…ser service layer; WIP.
…/map-of-pi-backend-react into online-shop/membership
swoocn
reviewed
Aug 11, 2025
swoocn
reviewed
Aug 11, 2025
| refData: U2URefDataType | ||
| ): Promise<IPaymentCrossReference> => { | ||
| try { | ||
| const newRef = new PaymentCrossReference({ | ||
| order_id: orderId, | ||
| order_id: refData.orderId, |
swoocn
reviewed
Aug 11, 2025
| refData: U2URefDataType | ||
| ): Promise<IPaymentCrossReference> => { | ||
| try { | ||
| const updatedRef = await PaymentCrossReference.findOneAndUpdate( | ||
| { order_id: orderId }, | ||
| { order_id: refData.orderId }, |
swoocn
reviewed
Aug 11, 2025
| throw error; | ||
| } | ||
| }; | ||
|
|
||
| export const createA2UPayment = async (a2uPaymentData: A2UPaymentDataType): Promise<IPayment | null> => { |
swoocn
reviewed
Aug 11, 2025
…ayment service layer; WIP.
swoocn
reviewed
Aug 11, 2025
swoocn
reviewed
Aug 11, 2025
| @@ -11,25 +11,23 @@ import SellerItem from "../models/SellerItem"; | |||
| import User from "../models/User"; | |||
| import { OrderStatusType } from "../models/enums/orderStatusType"; | |||
| import { OrderItemStatusType } from "../models/enums/orderItemStatusType"; | |||
| import { IOrder, IUser, NewOrder, PickedItems } from "../types"; | |||
| import { IOrder, NewOrder } from "../types"; | |||
| import logger from "../config/loggingConfig"; | |||
|
|
|||
| export const createOrder = async ( | |||
| orderData: NewOrder, | |||
…; resolve unit tests in payment helper layer; misc cleanup; WIP.
…mpt to fix build.
…into payment helper function.
swoocn
reviewed
Aug 15, 2025
| user_id: user?._id, | ||
| pi_uid: user?.pi_uid, | ||
| membership_class, | ||
| membership_expiration: membership_duration ? new Date(today.getTime() + durationMs) : null, |
There was a problem hiding this comment.
membership_expiration -> membership_expiry_date
swoocn
reviewed
Aug 15, 2025
| if (newRank > currentRank || newRank < currentRank) { | ||
| Object.assign(existing, { | ||
| membership_class, | ||
| membership_expiration: new Date(today.getTime() + durationMs), |
There was a problem hiding this comment.
membership_expiration -> membership_expiry_date
swoocn
reviewed
Aug 15, 2025
| } from "../models/enums/membershipClassType"; | ||
| import { IMembership, IUser, MembershipOption } from "../types"; | ||
|
|
||
| import logger from "../config/loggingConfig"; |
swoocn
reviewed
Aug 15, 2025
| existing.membership_expiry_date = null; | ||
| existing.mappi_balance = 1; | ||
| } | ||
| // If not expired, just add 1 mappi to the existing balance |
There was a problem hiding this comment.
This comment seems to contradict your implementation. We still want to add +1 Mappi regardless of whether the user’s existing membership is expired. I’ll go ahead and remove the comment @adisa39.
swoocn
reviewed
Aug 15, 2025
| return membership || null; | ||
| }; | ||
|
|
||
| export const updateOrRenewMembership = async ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor @DarinHajou membership implementation to use centralized membership information for scalability and integrated Pi payment for membership.