Skip to content

Notifications: Notification popup appeared, but zero in list screen #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

swoocn
Copy link
Member

@swoocn swoocn commented Jul 17, 2025

Introduce optional 'status' flag to getNotifications endpoint to optimize fetch notifications queries from FE.

[see commits]

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
map-of-pi-backend-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 4:03pm

@swoocn
Copy link
Member Author

swoocn commented Jul 17, 2025

[Swagger UI screenshot of updated getNotifications API operation]

image

Copy link
Member

@DarinHajou DarinHajou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like filtering logic works! Btw, did you fix the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants