Feature/membership payment final #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…membership, and deducting mappi balance
…ship, and deduct mappi
|
I'll be pushing some adjustments to your PR @DarinHajou; stay tuned! |
…/map-of-pi/map-of-pi-backend-react into feature/membership-payment-final
swoocn
reviewed
Apr 27, 2025
There was a problem hiding this comment.
Nice! But the script can certainly be optimized to eliminate the N+1 queries.
swoocn
reviewed
May 1, 2025
| const { membership_class, membership_duration, mappi_allowance } = req.body; | ||
|
|
||
| // Basic input validation | ||
| if ( |
There was a problem hiding this comment.
We could potentially use a schema validator to reduce manual validation and improve leverage across our controllers. 🤫
|
This PR includes a lot of changes that will conflict with the Order and Payment updates in Haycoder’s PR. I think it would be more efficient to prioritize reviewing his PR first, then revisit yours afterward to minimize merge issues. Thanks for your patience—please hold off for now @DarinHajou. |
tays965
previously approved these changes
May 16, 2025
swoocn
dismissed
tays965’s stale review
Unknown entity; not on the Map of Pi Dev team.
…/map-of-pi/map-of-pi-backend-react into feature/membership-payment-final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch (feature/membership-payment-final) builds directly on top of feature/membership-system-refactor, finalizing the U2A Pi payment flow for membership upgrades. All the main logic is in place, including the controller, model updates, and route setup.
It’s functional, but I’d suggest handling edge cases like duplicate payments and late completions in a separate branch to keep this one focused and clean.