Feature/membership system #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…membership, and deducting mappi balance
… IUserSettings type
…ship, and deduct mappi
…emove deductMappi function
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A bit confused @DarinHajou - so did we not decide to go with a separate Membership model as per the updated DB schema document?
|
swoocn
reviewed
Dec 8, 2024
| @@ -54,8 +54,26 @@ const userSettingsSchema = new Schema<IUserSettings>( | |||
| required: false, | |||
| default: [0, 0] | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
Why didn't we just create a separate Membership model? 🤔
Curious about your thoughts with potential scaling down the road..
swoocn
requested review from
joey364,
omotoshoayomikun,
amt-fredrick-amoako,
soleil00 and
Frankdevlopes
swoocn
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Could you clarify if this Tiers model is intended solely for informational purposes? If so, I don't anticipate the data needing to be changed very much and find the BE addition unnecessary overhead. Thoughts about treating the data as static content and presented on the FE.. perhaps in a JSON file?
|
This PR is superseded by #220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fully functional membership system to the backend, enabling management of user tiers, balances, and membership expiration. Key changes include adding membership_class, mappi_balance, and membership_expiration fields to the UserSettings model to track and manage user membership details effectively. In addition, a dedicated Tiers model was created to define and manage membership tiers.
The backend now provides all necessary functionality to handle membership management. Next steps involve integrating it ot the frontend UI and implementing payment using the Pi SDK for upgrading membership.