Skip to content

Commit 1e8407f

Browse files
committed
Revert "svn: prevent hanging when reading output from pipes"
This reverts commit 0c060a6 (#254). As per discussion in #259, use of 'a' for pipe type is not documented in the PHP manual [1], and the proc_open() call does not work with it (STDERR returns no output). [1]: http://php.net/manual/en/function.proc-open.php
1 parent 0c060a6 commit 1e8407f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

SourceSVN/SourceSVN.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ private function svn_run( $p_cmd, $p_repo = null )
324324

325325
$t_svn_proc = proc_open(
326326
$t_svn_cmd,
327-
array( array( 'pipe', 'r' ), array( 'pipe', 'w' ), array( 'pipe', 'a' ) ),
327+
array( array( 'pipe', 'r' ), array( 'pipe', 'w' ), array( 'pipe', 'w' ) ),
328328
$t_pipes
329329
);
330330

0 commit comments

Comments
 (0)