Skip to content

Commit 0c060a6

Browse files
FSD-Christian-ADMdregad
authored andcommitted
svn: prevent hanging when reading output from pipes
This occurs even on non-windows machines. Fixed by opening STDERR in append mode, as per http://php.net/manual/en/function.proc-open.php#97012 Fixes #254
1 parent c99ca47 commit 0c060a6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

SourceSVN/SourceSVN.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ private function svn_run( $p_cmd, $p_repo = null )
324324

325325
$t_svn_proc = proc_open(
326326
$t_svn_cmd,
327-
array( array( 'pipe', 'r' ), array( 'pipe', 'w' ), array( 'pipe', 'w' ) ),
327+
array( array( 'pipe', 'r' ), array( 'pipe', 'w' ), array( 'pipe', 'a' ) ),
328328
$t_pipes
329329
);
330330

0 commit comments

Comments
 (0)