Implement modular approach to commands. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the commands are now located in their corresponding files under the cmds directory.
All files under cmds directory will be checked for linting.
manrajgrover
requested changes
Jul 1, 2018
There was a problem hiding this comment.
@armansujoyan I've left a few comments which need attention. Overall looks great!
cmds/standings.js
Outdated
| const updateMessage = helpers.updateMessage; | ||
| const standingsHelper = helpers.standingsHelper; | ||
|
|
||
| const footballRequest = request.defaults({ |
There was a problem hiding this comment.
Let's move this to separate utility file for scores, standings and fixtures.
There was a problem hiding this comment.
You mean creating separate files for scores, fixtures and standings instead of having one helper.js right?
There was a problem hiding this comment.
No, let's keep one request_utils.js which exports this object.
cmds/standings.js
Outdated
| const leagueIds = require('../leagueIds'); | ||
|
|
||
| const updateMessage = helpers.updateMessage; | ||
| const standingsHelper = helpers.standingsHelper; |
There was a problem hiding this comment.
helpers.standingsHelper -> helpers.standings
cmds/config.js
Outdated
| obj.API_KEY = answers.API_KEY; | ||
| } | ||
|
|
||
| fs.writeFileSync(path.resolve(__dirname, 'config.json'), JSON.stringify(obj, null, 2), 'utf8'); |
There was a problem hiding this comment.
This config file should be written in root directory and not in cmds. Please fix the same.
manrajgrover
approved these changes
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
Commands are moved to their corresponding files. This modular approach will make it more clear and easy to use.
Link to YARGS
Official documentation of modular approach.
Related Issues and Discussions
Enhancement: Separate commands into modules. #41
People to notify
@manrajgrover