Skip to content

Add subsetsum check #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

Add subsetsum check #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions dp/subsetsum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
def isSubsetSum (items, length, summ):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the comment stating what does the module/function do. Also, include the doctest in the comments.
Doctest reference - https://docs.python.org/2/library/doctest.html

if summ == 0:
return True
if length == 0 and summ != 0:
return False

if (items[length - 1] > summ):
return isSubsetSum(items, length - 1, summ);

return isSubsetSum(items, length - 1, summ) or isSubsetSum(items, length - 1, summ - items[length - 1])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the code runs in an exponential time. Please try to optimize using Dynamic programming.


if __name__ == '__main__':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the test cases in a separate file under the test directory. Check out other test cases which use the pytest to do the testing.
Pytest documentation - https://docs.pytest.org/en/latest/contents.html

data = [1, 3, 5, 9, 12, 6, 2]
summ = 11
length = len(data)

if (isSubsetSum(data, length, summ) == True):
print('This set has subsetsum')
else:
print('No subsetsum')