Skip to content

Conversation

Alex-PLACET
Copy link
Collaborator

No description provided.

@Alex-PLACET Alex-PLACET self-assigned this Sep 16, 2025
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.97%. Comparing base (7017b2d) to head (00e7dad).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         100      100           
  Lines        7649     7649           
=======================================
  Hits         6729     6729           
  Misses        920      920           
Flag Coverage Δ
unittests 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comparative benchmarks between sparrow and Apache Arrow libraries to enable performance comparisons. The implementation includes new build options, dependency management, and comprehensive benchmark suites.

  • Adds comparative benchmarking infrastructure with Apache Arrow as a dependency
  • Updates various dependency versions (date, doctest, catch2, doxygen)
  • Enhances documentation with new sections on range access methods and iterator behavior

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/source/typed_array.md Adds documentation for range methods and clarifies nullable return types
conanfile.py Adds comparative benchmarks option and updates dependency versions
cmake/external_dependencies.cmake Adds extensive Apache Arrow dependency configuration
benchmarks/comparative/benchmark_primitive.cpp Implements comprehensive benchmarks comparing sparrow vs Arrow performance
benchmarks/comparative/CMakeLists.txt Sets up build configuration for comparative benchmarks
benchmarks/CMakeLists.txt Integrates comparative benchmarks into main build
CMakeLists.txt Adds BUILD_COMPARATIVE_BENCHMARKS option
.github/workflows/benchmarks.yml Updates CI to run comparative benchmarks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant