-
Notifications
You must be signed in to change notification settings - Fork 21
Add comparative benchmarks #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add comparative benchmarks #565
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 87.97% 87.97%
=======================================
Files 100 100
Lines 7649 7649
=======================================
Hits 6729 6729
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comparative benchmarks between sparrow and Apache Arrow libraries to enable performance comparisons. The implementation includes new build options, dependency management, and comprehensive benchmark suites.
- Adds comparative benchmarking infrastructure with Apache Arrow as a dependency
- Updates various dependency versions (date, doctest, catch2, doxygen)
- Enhances documentation with new sections on range access methods and iterator behavior
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
docs/source/typed_array.md | Adds documentation for range methods and clarifies nullable return types |
conanfile.py | Adds comparative benchmarks option and updates dependency versions |
cmake/external_dependencies.cmake | Adds extensive Apache Arrow dependency configuration |
benchmarks/comparative/benchmark_primitive.cpp | Implements comprehensive benchmarks comparing sparrow vs Arrow performance |
benchmarks/comparative/CMakeLists.txt | Sets up build configuration for comparative benchmarks |
benchmarks/CMakeLists.txt | Integrates comparative benchmarks into main build |
CMakeLists.txt | Adds BUILD_COMPARATIVE_BENCHMARKS option |
.github/workflows/benchmarks.yml | Updates CI to run comparative benchmarks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.