Copy tracker #555
Open
Copy tracker #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
copy_tracker
branch
from
1cb5ce5 to
2d449d9
Compare
Alex-PLACET
approved these changes
Sep 5, 2025
|
|
||
| TEST_CASE("copy semantic") | ||
| { | ||
| #ifdef SPARROW_TRACK_COPIES |
There was a problem hiding this comment.
I think we should always track the copies in the tests
There was a problem hiding this comment.
I agree but we should keep it as an opt-in; package managers may want to run the tests, but release without the copy tracking, and that would mean building the library twice.
JohanMabille
force-pushed
the
copy_tracker
branch
from
8282c5b to
888df8f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
- Coverage 87.99% 87.88% -0.11%
==========================================
Files 100 101 +1
Lines 7654 7695 +41
==========================================
+ Hits 6735 6763 +28
- Misses 919 932 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alex-PLACET
approved these changes
Oct 3, 2025
JohanMabille
force-pushed
the
copy_tracker
branch
from
c34b30f to
7e16ea5
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures on Windows should be fixed with #554
Failures on OSX shoud be fixed with #556