Improve StageResult printout
#2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
requested review from
IvoDD,
alexowens90 and
poodlewars
as code owners
IvoDD
approved these changes
Nov 17, 2025
Collaborator
IvoDD
left a comment
IvoDD
left a comment
There was a problem hiding this comment.
Looks good. Can you include an example in the PR description of the new format of the stage result, so that it is visible from the release notes?
cpp/arcticdb/entity/stage_result.hpp
Outdated
| auto transform_view = | ||
| stage_result.staged_segments | std::views::transform([](const auto& key) { | ||
| return arcticdb::entity:: | ||
| formattable<arcticdb::entity::AtomKey, arcticdb::entity::DisplayAtomKeyFormat>(key); |
Collaborator
There was a problem hiding this comment.
Nit: Can we use key.view_human() here?
ognyanstoimenov
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Improve the readability of
StageResultalong with atom keys' printoutNew
StageResultprintout example:StageResult(staged_segments=[Key(type=b, id='sym', version_id=0, content_hash=0xac454fbcb62cd989, creation_ts=1763562571272342532, start_index=1735689600000000000, end_index=1735776000000000001), Key(type=b, id='sym', version_id=0, content_hash=0x14e310dcc399815e, creation_ts=1763562571272634201, start_index=1735862400000000000, end_index=1735862400000000001)])New key printout example:
Key(type=b, id='sym', version_id=0, content_hash=0xac454fbcb62cd989, creation_ts=1763562571272342532, start_index=1735689600000000000, end_index=1735776000000000001)Docstring for the class has been added to the docs website as well.
Any other comments?
Checklist
Checklist for code changes...