Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bandai/wswan.cpp, bandai/wswan_v.cpp: Updates/Cleanups: #13469

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Mar 12, 2025

Common:

  • Move palette related functions into bandai/wswan_v.cpp

bandai/wswan.cpp:

  • Remove unused gfxdecode
  • Make some variables constant
  • Fix spacings

bandai/wswan_v.cpp:

  • Add device_palette_interface for palette functions
  • Split wonderswan color VDP device class into separated class
  • Fix emulation incorrections
  • Remove unused variables
  • Reduce unnecessary function
  • Reduce duplicates
  • Fix typename for boolean flags
  • Fix spacings
  • Fix typo

reference: https://ws.nesdev.org/wiki/WSdev_Wiki

cam900 added 2 commits March 12, 2025 23:22
Common:
- Move palette related functions into bandai/wswan_v.cpp

bandai/wswan.cpp:
- Remove unused gfxdecode
- Make some variables constant
- Fix spacings

bandai/wswan_v.cpp:
- Split wonderswan color VDP device class into separated class
- Remove unused variables
- Reduce duplicates
- Fix typename for boolean flags
- Fix spacings
@cam900
Copy link
Contributor Author

cam900 commented Mar 13, 2025

This PR after 87431d9:
mame wswan buffers -bench 90:
Average speed: 5290.27% (89 seconds)
Average speed: 5143.41% (89 seconds)
Average speed: 5171.78% (89 seconds)

mame wscolor buffers -bench 90:
Average speed: 5112.05% (89 seconds)
Average speed: 5188.16% (89 seconds)
Average speed: 5193.35% (89 seconds)

mame wscolor bluewing -bench 90:
Average speed: 2645.54% (89 seconds)
Average speed: 2700.49% (89 seconds)
Average speed: 2661.19% (89 seconds)

After some removal of virtual functions, then Performance reduction has been reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants