Gfx save #13430
Open
Gfx save #13430
+1,549
−1,340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir respective .h and .cpp files.
Moved gfx_viewer out of anonymous namespace.
Renamed gfxWriter class to gfx_writer. Made gfx_writer class friend of gfx_viewer class. Changed bitmap_rgb32 to bitmap_argb32 for transparency support. Sorted out #include.
…o a PNG file. The file is saved under the gfxsave directory, it will be created if needed.
|
Hello, Please, let me know. |
|
It looks like workflows are still awaiting approval. |
galibert
reviewed
Mar 13, 2025
src/frontend/mame/ui/gfx_writer.cpp
Outdated
|
|
||
| bitmap_argb32 gfx_writer::getBitmap(int xCells, int yCells, gfx_viewer::gfxset::setinfo& set, gfx_element& gfx) const | ||
| { | ||
| auto cellXpix{ (set.m_rotate & ORIENTATION_SWAP_XY) ? gfx.height() : gfx.width() }; |
There was a problem hiding this comment.
You seem to like that method of initialization for scalar variables. I know it's correct, but it's extremely unusual. We try to avoid unusual when possible, so it would be nice to switch back to the standard '='.
There was a problem hiding this comment.
Noted.
I updated te source code accordingly.
galibert
reviewed
Mar 13, 2025
Updated variables initialisation to coding standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the possibility to save the currently displayed gfx set using the snapshot hotkey (default F12).
The file (PNG) will be saved under the gfxsave directory wich will be created if needed).