-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document that mamba 2 only supports trailing globs in version strings #3783
base: main
Are you sure you want to change the base?
Conversation
fde6384
to
32b33b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jdblischak for opening this!
@@ -40,6 +40,9 @@ Breaking changes include: | |||
- A new config ``order_solver_request`` (default true) can be used to order the dependencies passed | |||
to the solver, getting order independent solutions. | |||
- Support for complex match specs such as ``pkg[md5=0000000000000]`` and ``pkg[build='^\d*$']``. | |||
- Dropped support for leading and internal globs in version strings (via | |||
redesigned ``VersionSpec``, which no longer handles version strings as a | |||
regex). Only trailing globs continue to be supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should advertise that leading and internal globs are definitely dropped as they may be supported later on...
An opinion @JohanMabille?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is more a regression that we want to fix shortly than a voluntary drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate that the plan is to fix this regression (and I would love that!), but mamba 2 was released about 4 months ago. Thus I think we need to better document this regression since this change in behavior was unexpected (eg #3601). Some ideas:
- What if we created a new Issue (something like "bug: fix leading and internal globs in version strings") and then pin that to the top of the Issues page?
- I could update the language in this PR to clarify that this breaking change is a temporary regression. Would that work? While it is only temporary, I feel like it deserves to be documented somewhere in the list of breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdblischak Yes the comments were only meant to say that we shouldn't document that this is dropped, only that it's a regression that we are aiming to fix. But it's definitely worth documenting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hind-M @JohanMabille I have updated the language to reflect the fact that this breaking change was unintentional and only temporary. I'm happy to update it further based on your preferred phrasing.
32b33b0
to
53aa64a
Compare
Mamba 1 supported leading and internal globs in version strings (eg
*.0.0
and0.*.0
respectively). Mamba 2 only supports trailing globs. This PR documents this breaking change.xref: #3601 (comment)
Here is a demonstration using libmambapy 2.0.5:
Here is a comparison of micromamba 2.0.5 versus 1.5.12: