Handle git+https pip urls (#3764)

mamba-org · Jan 23, 2025 · 617be25 · 617be25
1 parent 9c856fd
commit 617be25
Show file tree

Hide file tree

Showing 5 changed files with 643 additions and 6 deletions.
diff --git a/libmamba/src/specs/package_info.cpp b/libmamba/src/specs/package_info.cpp
@@ -225,6 +225,20 @@ namespace mamba::specs
             }
         }
 
+        // A git repository URL over https and used by `pip`
+        // git+https://<repository-url>@<commit|branch|tag>#egg=<package-name>
+        if (util::starts_with(str, "git+https"))
+        {
+            auto pkg = PackageInfo();
+            pkg.package_url = str;
+            const std::string pkg_name_marker = "#egg=";
+            if (const auto idx = str.rfind(pkg_name_marker); idx != std::string_view::npos)
+            {
+                pkg.name = str.substr(idx + pkg_name_marker.length());
+            }
+            return pkg;
+        }
+
         return make_unexpected_parse(fmt::format(R"(Fail to parse PackageInfo URL "{}")", str));
     }
 

diff --git a/libmamba/tests/src/specs/test_package_info.cpp b/libmamba/tests/src/specs/test_package_info.cpp
@@ -78,6 +78,15 @@ namespace
             static constexpr std::string_view url = "https://conda.anaconda.org/conda-forge/linux-64/pkg.conda";
             REQUIRE_FALSE(PackageInfo::from_url(url).has_value());
         }
+
+        SECTION("git+https://github.com/urllib3/[email protected]#egg=urllib3")
+        {
+            static constexpr std::string_view url = "git+https://github.com/urllib3/[email protected]#egg=urllib3";
+            auto pkg = PackageInfo::from_url(url).value();
+
+            REQUIRE(pkg.name == "urllib3");
+            REQUIRE(pkg.package_url == url);
+        }
     }
 
     TEST_CASE("PackageInfo serialization")