Skip to content

Fix typos #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions malsim/mal_simulator.py
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def _attacker_reward(attacker_state: MalSimAttackerState):
"""
Calculate current attacker reward by adding this steps
compromised node rewards to the previous attacker reward.
Can be overriden by subclass to implement custom reward function.
Can be overridden by subclass to implement custom reward function.

Args:
- attacker_state: the attacker state before nodes were compromised
Expand All @@ -499,7 +499,7 @@ def _defender_reward(defender_state: MalSimDefenderState):
"""
Calculate current defender reward by subtracting this steps
compromised/enabled node rewards from the previous defender reward.
Can be overriden by subclass to implement custom reward function.
Can be overridden by subclass to implement custom reward function.

Args:
- defender_state: the defender state before defenses were enabled
Expand All @@ -517,7 +517,7 @@ def _defender_reward(defender_state: MalSimDefenderState):
@staticmethod
def _attacker_is_terminated(attacker_state: MalSimAttackerState) -> bool:
"""Check if attacker is terminated
Can be overriden by subclass for custom termination condition.
Can be overridden by subclass for custom termination condition.

Args:
- attacker_state: the attacker state to check for termination
Expand All @@ -530,7 +530,7 @@ def _defender_is_terminated(
attacker_agent_states: list[MalSimAttackerState]
) -> bool:
"""Check if defender is terminated
Can be overriden by subclass for custom termination condition.
Can be overridden by subclass for custom termination condition.

Args:
- defender_state: the defender state to check for termination
Expand Down
2 changes: 1 addition & 1 deletion tests/test_scenario.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def test_load_scenario_observability_given():
"""Load a scenario with observability settings given and
make sure observability is applied correctly"""

# Load scenario with observability specifed
# Load scenario with observability specified
attack_graph, _ = load_scenario(
path_relative_to_tests(
'./testdata/scenarios/simple_filtered_observability_scenario.yml')
Expand Down