Skip to content

chore: update rust edition to 2024 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

makspll
Copy link
Owner

@makspll makspll commented Aug 19, 2025

Summary

About time!

Copy link

semanticdiff-com bot commented Aug 19, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/lad_backends/mdbook_lad_preprocessor/src/markdown.rs  100% smaller
  crates/bevy_api_gen/src/passes/find_methods_and_fields.rs  91% smaller
  crates/bevy_mod_scripting_core/src/bindings/function/from_ref.rs  91% smaller
  crates/bevy_mod_scripting_core/src/bindings/reference.rs  89% smaller
  crates/testing_crates/script_integration_test_harness/src/parse.rs  88% smaller
  tests/script_tests.rs  88% smaller
  crates/bevy_mod_scripting_derive/src/derive/mod.rs  87% smaller
  crates/bevy_mod_scripting_derive/src/derive/script_bindings.rs  86% smaller
  crates/bevy_mod_scripting_derive/src/derive/script_globals.rs  86% smaller
  crates/bevy_mod_scripting_core/src/bindings/script_system.rs  84% smaller
  crates/bevy_api_gen/src/bin/main.rs  84% smaller
  crates/bevy_mod_scripting_core/src/bindings/script_value.rs  83% smaller
  crates/lad_backends/mdbook_lad_preprocessor/tests/book_integration_tests.rs  80% smaller
  crates/lad_backends/mdbook_lad_preprocessor/src/sections.rs  79% smaller
  crates/bevy_mod_scripting_core/src/reflection_extensions.rs  79% smaller
  benches/benchmarks.rs  78% smaller
  xtask/src/main.rs  76% smaller
  crates/bevy_mod_scripting_core/src/extractors.rs  74% smaller
  crates/bevy_mod_scripting_core/src/handler.rs  73% smaller
  crates/bevy_mod_scripting_core/src/script/script_context.rs  67% smaller
  crates/bevy_api_gen/src/template.rs  66% smaller
  crates/testing_crates/test_utils/src/test_data.rs  66% smaller
  crates/bevy_api_gen/src/passes/populate_template_data.rs  65% smaller
  crates/ladfile_builder/src/lib.rs  64% smaller
  crates/bevy_mod_scripting_core/src/lib.rs  62% smaller
  crates/lad_backends/mdbook_lad_preprocessor/src/lib.rs  62% smaller
  crates/testing_crates/script_integration_test_harness/src/scenario.rs  55% smaller
  crates/bevy_api_gen/src/plugin.rs  52% smaller
  crates/bevy_api_gen/src/meta.rs  51% smaller
  crates/testing_crates/script_integration_test_harness/src/test_functions.rs  50% smaller
  crates/bevy_mod_scripting_functions/src/core.rs  50% smaller
  crates/bevy_api_gen/src/callback.rs  46% smaller
  crates/bevy_mod_scripting_core/src/asset.rs  45% smaller
  examples/docgen.rs  44% smaller
  crates/bevy_api_gen/src/passes/find_trait_impls.rs  42% smaller
  crates/languages/bevy_mod_scripting_rhai/src/bindings/reference.rs  38% smaller
  crates/bevy_api_gen/src/import_path.rs  38% smaller
  crates/bevy_api_gen/src/passes/codegen.rs  36% smaller
  crates/languages/bevy_mod_scripting_lua/src/lib.rs  26% smaller
  crates/languages/bevy_mod_scripting_lua/src/bindings/reference.rs  25% smaller
  .github/workflows/bevy_mod_scripting.yml  25% smaller
  crates/languages/bevy_mod_scripting_rhai/src/lib.rs  25% smaller
  crates/bevy_api_gen/src/passes/cache_traits.rs  21% smaller
  crates/languages/bevy_mod_scripting_lua/src/bindings/script_value.rs  20% smaller
  crates/bevy_api_gen/src/feature_graph.rs  18% smaller
  crates/bevy_mod_scripting_core/src/script/context_key.rs  15% smaller
  crates/bevy_mod_scripting_core/src/error.rs  15% smaller
  crates/testing_crates/script_integration_test_harness/src/lib.rs  14% smaller
  crates/bevy_mod_scripting_core/src/commands.rs  13% smaller
  crates/bevy_mod_scripting_core/src/event.rs  13% smaller
  crates/bevy_api_gen/src/args.rs  10% smaller
  crates/bevy_api_gen/src/bin/driver.rs  7% smaller
  crates/ladfile_builder/src/plugin.rs  1% smaller
  Cargo.toml Unsupported file format
  build_scripts.sh Unsupported file format
  crates/bevy_api_gen/Cargo.bootstrap.toml Unsupported file format
  crates/bevy_api_gen/Cargo.toml Unsupported file format
  crates/bevy_api_gen/rust-toolchain.toml Unsupported file format
  crates/bevy_api_gen/src/driver/license Unsupported file format
  crates/bevy_api_gen/src/driver/mod.rs  0% smaller
  crates/bevy_api_gen/src/driver/plugin.rs  0% smaller
  crates/bevy_api_gen/src/lib.rs  0% smaller
  crates/bevy_mod_scripting_core/Cargo.toml Unsupported file format
  crates/bevy_mod_scripting_core/src/bindings/allocator.rs  0% smaller
  crates/bevy_mod_scripting_core/src/context.rs  0% smaller
  crates/bevy_mod_scripting_core/src/runtime.rs  0% smaller
  crates/bevy_mod_scripting_core/src/script/mod.rs  0% smaller
  crates/bevy_mod_scripting_derive/Cargo.toml Unsupported file format
  crates/bevy_mod_scripting_derive/src/derive/get_type_dependencies.rs  0% smaller
  crates/bevy_mod_scripting_functions/Cargo.toml Unsupported file format
  crates/lad_backends/mdbook_lad_preprocessor/Cargo.toml Unsupported file format
  crates/lad_backends/mdbook_lad_preprocessor/src/main.rs  0% smaller
  crates/ladfile/Cargo.toml Unsupported file format
  crates/ladfile/src/lib.rs  0% smaller
  crates/ladfile_builder/Cargo.toml Unsupported file format
  crates/languages/bevy_mod_scripting_lua/Cargo.toml Unsupported file format
  crates/languages/bevy_mod_scripting_rhai/Cargo.toml Unsupported file format
  crates/languages/bevy_mod_scripting_rhai/src/bindings/script_value.rs  0% smaller
  crates/languages/bevy_mod_scripting_rune/Cargo.toml Unsupported file format
  crates/testing_crates/script_integration_test_harness/Cargo.toml Unsupported file format
  crates/testing_crates/test_utils/Cargo.toml Unsupported file format
  examples/game_of_life.rs Unsupported file format
  src/lib.rs  0% smaller
  src/prelude.rs  0% smaller
  xtask/Cargo.toml Unsupported file format
  xtask/templates/settings.json.tera Unsupported file format

@makspll makspll enabled auto-merge (squash) August 19, 2025 21:50
@makspll
Copy link
Owner Author

makspll commented Aug 21, 2025

This is taking me on a journey, since some of the features in this edition require much newer nightly versions, and a version of rustc_plugin doesn't exist for those yet

Copy link
Contributor

🐰 Bencher Report

Branchchore/update-rust-edition
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,622.70 ns
(-22.21%)Baseline: 4,657.24 ns
6,132.26 ns
(59.08%)
component/access Rhai📈 view plot
🚷 view threshold
5,408.30 ns
(-17.69%)Baseline: 6,570.76 ns
7,860.98 ns
(68.80%)
component/get Lua📈 view plot
🚷 view threshold
2,230.20 ns
(-19.13%)Baseline: 2,757.70 ns
3,471.88 ns
(64.24%)
component/get Rhai📈 view plot
🚷 view threshold
4,051.40 ns
(-16.20%)Baseline: 4,834.36 ns
5,850.67 ns
(69.25%)
conversions/Mut::from📈 view plot
🚷 view threshold
82.93 ns
(-30.13%)Baseline: 118.68 ns
219.04 ns
(37.86%)
conversions/Ref::from📈 view plot
🚷 view threshold
78.48 ns
(-32.72%)Baseline: 116.65 ns
216.70 ns
(36.22%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
269.69 ns
(-45.68%)Baseline: 496.50 ns
1,037.64 ns
(25.99%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,361.90 ns
(-11.43%)Baseline: 1,537.60 ns
2,102.26 ns
(64.78%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
25.46 ns
(-30.96%)Baseline: 36.87 ns
61.70 ns
(41.26%)
conversions/Val::from_into📈 view plot
🚷 view threshold
319.23 ns
(-3.59%)Baseline: 331.11 ns
435.95 ns
(73.23%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,645.70 ns
(-18.93%)Baseline: 2,029.85 ns
2,440.43 ns
(67.43%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,370.50 ns
(-20.80%)Baseline: 1,730.37 ns
2,173.79 ns
(63.05%)
function/call Lua📈 view plot
🚷 view threshold
232.87 ns
(-13.63%)Baseline: 269.61 ns
328.08 ns
(70.98%)
function/call Rhai📈 view plot
🚷 view threshold
391.07 ns
(-23.30%)Baseline: 509.84 ns
654.18 ns
(59.78%)
loading/empty Lua📈 view plot
🚷 view threshold
55,158.00 ns
(-34.24%)Baseline: 83,873.76 ns
130,483.33 ns
(42.27%)
loading/empty Rhai📈 view plot
🚷 view threshold
297,870.00 ns
(-66.05%)Baseline: 877,306.47 ns
2,123,994.76 ns
(14.02%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
6,890.00 ns
(-10.94%)Baseline: 7,736.75 ns
8,950.33 ns
(76.98%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,001.80 ns
(-17.77%)Baseline: 7,299.01 ns
8,389.27 ns
(71.54%)
query/10 entities Lua📈 view plot
🚷 view threshold
18,267.00 ns
(-22.86%)Baseline: 23,680.25 ns
29,675.17 ns
(61.56%)
query/10 entities Rhai📈 view plot
🚷 view threshold
18,655.00 ns
(-21.28%)Baseline: 23,699.18 ns
28,160.48 ns
(66.25%)
query/100 entities Lua📈 view plot
🚷 view threshold
40,988.00 ns
(-14.92%)Baseline: 48,175.76 ns
59,142.71 ns
(69.30%)
query/100 entities Rhai📈 view plot
🚷 view threshold
32,327.00 ns
(-14.53%)Baseline: 37,824.80 ns
46,393.74 ns
(69.68%)
query/1000 entities Lua📈 view plot
🚷 view threshold
252,970.00 ns
(-18.17%)Baseline: 309,123.92 ns
372,174.11 ns
(67.97%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
162,200.00 ns
(-22.08%)Baseline: 208,166.67 ns
285,054.42 ns
(56.90%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,531.40 ns
(-14.22%)Baseline: 6,448.12 ns
7,364.81 ns
(75.11%)
reflection/10 Rhai📈 view plot
🚷 view threshold
14,938.00 ns
(-8.65%)Baseline: 16,352.78 ns
17,864.14 ns
(83.62%)
reflection/100 Lua📈 view plot
🚷 view threshold
47,941.00 ns
(-9.87%)Baseline: 53,193.37 ns
59,049.97 ns
(81.19%)
reflection/100 Rhai📈 view plot
🚷 view threshold
719,960.00 ns
(-3.89%)Baseline: 749,107.06 ns
870,322.27 ns
(82.72%)
resource/access Lua📈 view plot
🚷 view threshold
3,219.00 ns
(-21.98%)Baseline: 4,125.95 ns
5,325.20 ns
(60.45%)
resource/access Rhai📈 view plot
🚷 view threshold
4,902.40 ns
(-16.46%)Baseline: 5,868.38 ns
7,197.09 ns
(68.12%)
resource/get Lua📈 view plot
🚷 view threshold
1,846.50 ns
(-19.83%)Baseline: 2,303.28 ns
2,910.15 ns
(63.45%)
resource/get Rhai📈 view plot
🚷 view threshold
3,612.70 ns
(-13.90%)Baseline: 4,195.94 ns
5,149.86 ns
(70.15%)
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant