Kay D rps challenge #2135
Open
Kay D rps challenge #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davekempsell
reviewed
Jun 6, 2022
| redirect ('/result') | ||
| end | ||
|
|
||
| get '/result' do |
There was a problem hiding this comment.
this is a clear and concise way of displaying who has won the game.
| end | ||
| end | ||
|
|
||
| feature 'player 1 chooses rock' do |
There was a problem hiding this comment.
Perhaps the second and third tests here are redundant if the first one is working?
| end | ||
|
|
||
| feature 'player 1 picks rock and player 2 picks paper' do | ||
| scenario 'shows player 1 as the winner' do |
There was a problem hiding this comment.
I think this line should say "shows player 2 as the winner"
| @player2 = player2 | ||
| end | ||
|
|
||
| def winner |
There was a problem hiding this comment.
I like this solution to the coding of the game of rock, paper, scissors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.