Tom O'Neill rps challenge #2120
Conversation
| visit("/") | ||
| expect(page.status_code).to eq(200) | ||
| end | ||
|
|
There was a problem hiding this comment.
Ahh nice to see an example of a test for this
| def random_move | ||
| ALLOWED_MOVES.sample | ||
| end | ||
|
|
There was a problem hiding this comment.
All of these .rb's are so CLEAN, so TIGHT, every function has a clear and distinct role. V tasty.
lib/game.rb
Outdated
| "paper scissors" => false, | ||
| "paper paper" => nil, | ||
| } | ||
|
|
There was a problem hiding this comment.
Ha much cleaner than mine. I saw some smart ones on codewars I was meaning to implement.
| def check_move_allowed(move) | ||
| fail 'Incorrect move' if !ALLOWED_MOVES.include?(move) | ||
| end | ||
|
|
There was a problem hiding this comment.
So have you implemented this in such a way as it requires the player enters another choice?
spec/game_spec.rb
Outdated
| expect(game.calculate_result('paper','scissors')).to eq false | ||
| end | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
All tests are comprehensive, v nice
| <% if @result == nil %> | ||
|
|
||
| It's a draw | ||
|
|
There was a problem hiding this comment.
Oooooo interesting, I totally forgot about how to place if/else logic within the html page. This opens it up a lot. Nice work
| <form action="/calculate_results" method="post"> | ||
| <button class= "selection" type="submit" value = "rock" name="choice"><img src='rock.png' alt="Rock" width="300" height="500" ></button> | ||
| <button class= "selection" type="submit" value = "paper" name="choice"><img src='paper.png' alt="Paper" width="300" height="500" ></button> | ||
| <button class= "selection" type="submit" value = "scissors" name="choice"><img src='scissors.png' alt="Scissors" width="300" height="500" ></button> |
There was a problem hiding this comment.
Ohhhhh that's why the pics were there :') hahahaa
2 participants
No description provided.