feat: add parent to work item comments — v0.2.14 - #57
Merged
Conversation
The v1 API accepts parent on comment create (the id of a top-level comment on the same work item to reply to) and returns it on read; the SDK types did not declare it, so a threaded reply could not be typed. Update request is left unchanged — re-parenting on edit is not a supported operation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package version changed from ChangesComment contract and package release
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change adds optional parent-comment support to existing work-item comment types without altering runtime endpoints or authorization behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prashant-Surya
approved these changes
Sep 2, 2026
Prashant-Surya
added a commit
that referenced
this pull request
Sep 9, 2026
Only conflict was the version: this branch had already bumped to 0.3.0 for the v2 surface, while main remained at 0.2.14. Kept 0.3.0 — main has published nothing past 0.2.14, and this adds an entire namespace. The other commit on main, "add parent to work item comment model and create request" (#57), touches src/models/Comment.ts, which is the v1 model. This branch never touched it, so it merged cleanly and both `parent` fields survive. No v2 mirror is needed: the v2 golden does not declare `parent` on work item comment create, so the capability does not exist on that surface yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014QwQ1tqb3831E7rezg5zqs
Prashant-Surya
added a commit
that referenced
this pull request
Sep 9, 2026
Two CI failures, one that fired and one that was waiting to. The build failed because the export snapshot was generated before merging main. That merge brought in `parent` on WorkItemComment and WorkItemCommentCreateRequest (v1 models, via #57), so both declarations legitimately changed shape while the snapshot still recorded the old hashes. Regenerated: exactly those two entries move, count unchanged at 1701, no additions and no removals. The guard was right. The second had not surfaced yet. `v2-golden-drift` regenerates constants.ts and requires it byte-identical, and the generator records its source path in the file header -- so the committed spelling must match the one CI passes, which the workflow documents as `../plane-ee/apps/api/plane/api_v2/core/schema/openapi`. An earlier commit here (3aab31d) rewrote that header to `../plane-ee-preview/...` when the golden was regenerated from a preview checkout, which would have failed the drift check the moment PLANE_EE_CHECKOUT_TOKEN was configured; the job is skipped without it, so nothing reported it. Regenerated against the same preview content with the path spelled as CI spells it: the header is the only line that differs, all 407 operations are identical. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014QwQ1tqb3831E7rezg5zqs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
parent?: stringtoWorkItemCommentandWorkItemCommentCreateRequest, and bumps the package to 0.2.14.The v1 API already accepts
parentwhen creating a work item comment — the id of a top-level comment on the same work item to reply to — and returns it on read, but the SDK types did not declare it, so a threaded reply could not be expressed.WorkItemCommentUpdateRequestis intentionally unchanged: re-parenting a comment on edit is not a supported operation (the comment is already addressed by its own id).Mirrors makeplane/plane-python-sdk#71 (
plane-sdk0.2.24).Verification
pnpm build—parent?: stringpresent on both types indist/types.bundle.d.tspnpm check:lint/pnpm check:format— clean (0 errors)Related
parentvalidation (same work item, top-level only): https://github.com/makeplane/plane-ee/pull/9339Summary by CodeRabbit
New Features
Chores