Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatto_trv06_radiatorvalve.yaml addon … Issue #2457 #2465

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

ciscolyon69
Copy link
Contributor

@ciscolyon69 ciscolyon69 commented Nov 5, 2024

addon Battery frost_protection scale_protection local_temperature_calibration Issue #2457
I copied the code from other device.
please check my code and tell me if you see a better way ?

@ciscolyon69
Copy link
Contributor Author

I need help to finish

[custom_components.tuya_local.device] Bureau received {"28": "AwYAANIIAACgDAAA0g4AAKASAADSFgAAoA==", "full_poll": false}
I know the solution = "schedule_monday": "06:00/21.0 08:00/16.0 12:00/21.0 14:00/16.0",
'HH:MM/C HH:MM/C HH:MM/C HH:MM/C HH:MM/C HH:MM/C'
how to put it in HA?
Koenkk/zigbee-herdsman-converters#8062 (comment)

it is not the solution

  - entity: select             
    name: Schedule             
    category: config           
    icon: "mdi:calendar-clock" 
    dps:                       
      - id: 28                 
        type: string           
        name: option           
        optional: true         
        mapping:               
          - dps_val: "1"       
            value: "Weekday+Weekend"
          - dps_val: "2"            
            value: "Mon-Sat+Sun"    
          - dps_val: "3"            
            value: "Daily"          

mapping:
- dps_val: 0
value: false
- value: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other devices that use a bitfield to indicate low battery, the low battery indication is a specific bit, and there will often be other bits indicating other things like charging. To avoid falsely indicating a low battery, it would be better to identify which bit is indicating low battery, and map that bit to true, with the default mapping being false.

- if C or F is used for relative temperatures, HA "converts" them when the user's temperature unit setting is different, which is wrong, because C to F conversion is not just scaling but a range shift as well. So relative temperatures such as calibration offset have to be in degrees without specifying the scale.
@make-all make-all merged commit 595e3d4 into make-all:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants